Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solana tokens support [LIVE-12069] #8119

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

feat: solana tokens support [LIVE-12069] #8119

wants to merge 27 commits into from
+1,696 −284

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Oct 16, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Solana accounts in LLD, LLM. Send tokens, receive tokens, view tokens

📝 Description

We need to fix and merge the solana priority fees before this one

Original work: hoodieshq#2

📝 Description

  • Finalized integration with SPL tokens on Solana.

Details:

  • Updated sub accounts sychronisation [coin-solana solana]
  • Added BURN operation type [LLD, libs/coin-framework, libs/ledgerjs/packages/types-live]
  • Added account sub header for displaying alert message for frozen tokens [LLD, LLM]
  • Disable staking modal for solana tokens [LLD]
  • Added additinal warning messages [LLM, LLD]
  • Fixed tx fee of token account (it should be in SOL) [LLM]
  • Implement functions (assignFromTokenAccountRaw, assignToTokenAccountRaw) for serialization of TokenAccount custom fields (like token "frozen" state) [libs/coin-framework, libs/ledgerjs/packages/types-live]
  • Enabled existing tokens integration tests and added additional few in bridge.integration.test.ts [coin-solana solana]
  • Added speculos tests for tokens [coin-solana solana]
  • Updated bridge.integration.test.ts snapshot [LLC solana]

Screenshots

image
image
image
image
image image image image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Oct 16, 2024
@Justkant Justkant requested review from a team as code owners October 16, 2024 18:02
@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:52pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:52pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:52pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:52pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:52pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Oct 16, 2024
@mikhd mikhd mentioned this pull request Oct 21, 2024
Open
9 tasks
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 7c21f2c to 9ddc7d7 Compare October 29, 2024 10:32
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 9ddc7d7 to 48f4d62 Compare November 4, 2024 08:18
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 48f4d62 to 18c1f45 Compare November 4, 2024 15:34
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 18c1f45 to daa5138 Compare November 13, 2024 10:33
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 075aba9 to 290295f Compare November 18, 2024 14:46
@live-github-bot live-github-bot bot added the cli label Nov 18, 2024
@Justkant Justkant requested a review from a team as a code owner November 18, 2024 16:12
Wozacosta
Wozacosta previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Justkant Justkant force-pushed the feat/solana-tokens-support branch from 6886149 to dc4e6a0 Compare November 19, 2024 16:31
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from dc4e6a0 to 00943c9 Compare November 19, 2024 17:01
mikhd and others added 26 commits December 2, 2024 13:51
@mikhd @Justkant
feat: add serialization of TokenAccount extra fields [coin-framework]
0ddfb7a
@mikhd @Justkant
feat: add burn operation type
61e0c0e
@mikhd @Justkant
feat: enable solana spl tokens import
7a7ba29
@mikhd @Justkant
feat: finish solana tokens integration into bridge [coin-solana]
60a660f
@mikhd @Justkant
chore: update solana bridge and speculos tests
c3ef9f4
@mikhd @Justkant
feat: display solana tokens in LLD
1496b0d
@mikhd @Justkant
feat: display solana tokens in LLM
3c3e6ca
@mikhd @Justkant
chore(LLC): add token account serialization test
0e58a96
@mikhd @Justkant
chore: add changeset
ec47795
@mikhd @Justkant
fix(LLD, LLM): token summary and device screens
72c77b3
@Justkant
fix: non existing param used for SPL Tokens
2e76e29
@Justkant
fix: wrong chainId for spl tokens
87e58c6 
Used the import:cal-tokens to update only spl data
@Justkant
fix: lint issue on missing break
3e25282
@Justkant
chore: update bridge integration test snapshot for solana
ff86e29
@Justkant
chore: update spl token snapshot
de4f6e5
@Justkant
feat: add solana testnet and devnet in supported currencies list
4574b72
@Justkant
fix: spl priority fees and transaction confirmation with blockHeight
204ee42
@Justkant
chore: add support links
e381a85
@Justkant
test: fix with solana testnet and devnet addition
6ab7030
@Justkant
chore: remove comments from review comments
b1a6120
@Justkant
fix: wallet-api spl usage
7aef832
@Justkant
fix: wallet-api spl token support
4c6e875
@Justkant
test: fix test expectation
ab5ceda
@Justkant
test: fix wrong findTokenById call and param
bf4ac3f
@Justkant
test: fix missing account type
09f1091
@Justkant
feat: add trusted name resolution for signTransaction
0154460
@Justkant Justkant force-pushed the feat/solana-tokens-support branch from c228a4e to 0154460 Compare December 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wozacosta Wozacosta Awaiting requested review from Wozacosta

@themooneer themooneer Awaiting requested review from themooneer

At least 1 approving review is required to merge this pull request.

Assignees

@Justkant Justkant

Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Justkant @Wozacosta @themooneer @mikhd