Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💬 LLM / LLD - Update Analytics Opt In Prompt wording #8243

Merged
merged 1 commit into from
Oct 30, 2024
Merged

💬 LLM / LLD - Update Analytics Opt In Prompt wording #8243

merged 1 commit into from
Oct 30, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Oct 29, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Update Analytics Opt In Prompt Wording to make sure we do not mention "tracking" as it causes a quiproquo with Apple's App Tracking Transparency Policy.

LLM

Screenshot 2024-10-29 at 17 23 41
Screenshot 2024-10-29 at 17 24 34

LLD

Screenshot 2024-10-29 at 17 17 53
Screenshot 2024-10-29 at 17 18 29

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:26pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:26pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:26pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:26pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:26pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Oct 29, 2024
@LucasWerey
Copy link
Contributor

Commitlint 📛

LucasWerey
LucasWerey previously approved these changes Oct 29, 2024
View reviewed changes
@cgrellard-ledger cgrellard-ledger force-pushed the support/update-analytics-opt-in-prompt-wording branch from 16eed62 to 633c50d Compare October 29, 2024 16:25
@cgrellard-ledger
Copy link
Contributor Author

cgrellard-ledger commented Oct 30, 2024 •
edited by live-github-bot bot
Loading

@cgrellard-ledger

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@cgrellard-ledger cgrellard-ledger merged commit 027b0dc into develop Oct 30, 2024
49 of 53 checks passed
@cgrellard-ledger cgrellard-ledger deleted the support/update-analytics-opt-in-prompt-wording branch October 30, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

@themooneer themooneer themooneer approved these changes

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgrellard-ledger @LucasWerey @themooneer