Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: πŸͺ› Updating send test scenarios to use cli #8423

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • Adding cli in send test scenarios (thx @Wozacosta πŸ’™)
  • removing speculos-checkSendAddress.json file

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 20, 2024 3:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 20, 2024 3:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 20, 2024 3:22pm
web-tools ⬜️ Ignored (Inspect) Nov 20, 2024 3:22pm

@VicAlbr VicAlbr marked this pull request as ready for review November 20, 2024 15:22
@VicAlbr VicAlbr requested review from a team as code owners November 20, 2024 15:22
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 20, 2024
@VicAlbr VicAlbr merged commit d347e83 into develop Nov 20, 2024
43 of 45 checks passed
@VicAlbr VicAlbr deleted the support/updating-send-test-with-cli branch November 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants