Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing watch:es for common #8424

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

Justkant
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached. Only doc and scripts changes
  • Covered by automatic tests. Tested locally as it's dev stuff
  • Impact of the changes:
    • LLD watch for common

πŸ“ Description

Follow up on #8365
Common watch mode would not work on common and I saw that I was also missing the watch:es for common where I thought it was not needed at first

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Nov 20, 2024
@Justkant Justkant requested a review from a team as a code owner November 20, 2024 17:27
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 20, 2024 5:29pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 20, 2024 5:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 20, 2024 5:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 20, 2024 5:29pm

Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Justkant Justkant merged commit 0430ab8 into develop Nov 21, 2024
55 checks passed
@Justkant Justkant deleted the support/watch-common branch November 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants