-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display incompatibility message for LNS swap, LIVE-14891, LIVE-14838, LIVE-14923 #8433
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 4 Skipped Deployments
|
d0f694f
to
44841be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to handle the renderHardwareUpdate
before the DeviceAction
component to avoid sending APDUs to the device while showing the message
What is your suggestion? |
β¦erHQ/ledger-live into feat/LIVE-14838-adds-lns-swap-error
Hey you'll want to move the I think we only need to target the new swap flows as the old native swap should not be used in prod anymore and the old platform startExchange modal is not used anymore by the wallet-api For this you can edit this file: https://github.com/LedgerHQ/ledger-live/blob/develop/apps/ledger-live-desktop/src/renderer/components/LiveAppDrawer.tsx#L162-L178 The main idea is that we don't want to call the |
apps/ledger-live-desktop/src/renderer/components/DeviceAction/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/LiveAppDrawer.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/LiveAppDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested a lot of cases with multiple devices and it now works perfectly, thx for the updates
β Checklist
npx changeset
was attached.π Description
Adds LNS incompatibility banner for TON, ADA and SPL Tokens.
β Context
π§ Checklist for the PR Reviewers