bugfix: revert useNFTCollections #8595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mcayuelas-ledger
force-pushed
the
bugfix/revert
branch
from
00a5299 to
ae25642
Compare
live-github-bot
bot
added
common
mcayuelas-ledger
force-pushed
the
bugfix/revert
branch
from
d0a01ee to
4d63b83
Compare
live-github-bot
bot
removed
common
live-github-bot
bot
added
common
KVNLS
requested changes
Dec 4, 2024
Comment on lines
88
to
94
| setNumberOfVisibleCollections( | ||
| numberOfVisibleCollections => numberOfVisibleCollections + INCREMENT, | ||
| ); | ||
| if (hasNextPage) { | ||
| fetchNextPage(); | ||
| } | ||
| }, [collectionsLength, fetchNextPage, hasNextPage]); | ||
| }, [fetchNextPage, hasNextPage]); |
There was a problem hiding this comment.
Why don't we use collectionsLength anymore?
| @@ -26,6 +26,7 @@ const useBreadCrumbModel = () => { | |||
| chains: [String(account?.currency.id)], | |||
| threshold: isThresholdValid(thresold) ? Number(thresold) : 75, | |||
| enabled: nftsFromSimplehashFeature?.enabled || false, | |||
| staleTime: nftsFromSimplehashFeature?.params?.staleTime, | |||
There was a problem hiding this comment.
I'm not sure if we want to use staleTime as now I have a request that is sent after some time when I stay on the Collection page. We don't want to send requests if LEdger Live stays open a while on the same page.
mcayuelas-ledger
force-pushed
the
bugfix/revert
branch
2 times, most recently
from
54104b3 to
d6a3263
Compare
mcayuelas-ledger
force-pushed
the
bugfix/revert
branch
from
d6a3263 to
20e9171
Compare
KVNLS
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers