Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/revert and tsd 4337 unexpected major service overuse release #8601

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Bugfix/revert and tsd 4337 unexpected major service overuse release #8601

merged 3 commits into from
Dec 4, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Dec 4, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

tsd-4337-unexpected-major-service-overuse

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested review from a team as code owners December 4, 2024 15:49
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 3:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 3:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 3:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 3:58pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Dec 4, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 61aedb7 into release Dec 4, 2024
52 of 59 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/revert-and-tsd-4337-unexpected-major-service-overuse-release branch December 4, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcayuelas-ledger @themooneer