Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LIVE-13952): allow SWAP_USER_IP to be given to swap app #8602

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Couto
Copy link
Contributor

@Couto Couto commented Dec 4, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

When running LLD, with SWAP_API_BASE=https://<url> SWAP_USER_IP=8.8.8.8 pnpm dev allow those environment variables to be given to the Swap App as queryParams, since those are used to define which API url to hit, and which IP should was the request forward from.

(This also fixes a bug with SWAP_API_BASE)

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Couto Couto requested a review from a team as a code owner December 4, 2024 16:02
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 4, 2024 4:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 4, 2024 4:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 4, 2024 4:02pm
web-tools ⬜️ Ignored (Inspect) Dec 4, 2024 4:02pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 4, 2024
@Couto Couto merged commit 5c497ba into develop Dec 4, 2024
54 checks passed
@Couto Couto deleted the feat/LIVE-13952-testing-mode-another-ip branch December 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants