Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-356][Playwright][Speculos] Fix solana stake flow #8605

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[QAA-356][Playwright][Speculos] Fix solana stake flow #8605

merged 3 commits into from
Dec 5, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 4, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD Speculos Stake tests

📝 Description

Following LIVE-14413, Solana stake modal change during Validator selection. This ticket adapts Speculos tests to these changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:56pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:56pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 4, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_356_playwright_fix_solana_stake branch from 630538d to 1d08606 Compare December 4, 2024 22:52
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 5, 2024 07:20
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners December 5, 2024 07:20
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_356_playwright_fix_solana_stake branch from a6c4184 to d6b3e2d Compare December 5, 2024 14:55
@ypolishchuk-ledger ypolishchuk-ledger merged commit ad18613 into develop Dec 5, 2024
41 checks passed
@ypolishchuk-ledger ypolishchuk-ledger deleted the support/qaa_356_playwright_fix_solana_stake branch December 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@mcoursier-ledger mcoursier-ledger mcoursier-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@Justkant Justkant Justkant approved these changes

@bharamboure-ledger bharamboure-ledger bharamboure-ledger left review comments

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abdurrahman-ledger @Justkant @ypolishchuk-ledger @mcoursier-ledger @bharamboure-ledger @mcayuelas-ledger