Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (llm) margin issue on my ledger screen #8607

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

LucasWerey
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • My Ledger

📝 Description

Screen.Recording.2024-12-05.at.11.12.55.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner December 5, 2024 10:16
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 10:16am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 5, 2024 10:16am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 10:16am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 10:16am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 5, 2024
@cgrellard-ledger
Copy link
Contributor

I tested and it works fine 👍

@LucasWerey LucasWerey merged commit c9e2ceb into develop Dec 5, 2024
41 of 42 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-15218 branch December 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants