-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(llm): π fix long Memo Tag issue on Cardano #8608
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 4 Skipped Deployments
|
8fb32ec
to
e4a8ded
Compare
TLDR I removed the last commit because I did one last test which went wrong and there's a minor bug on the backend. If I send a memo with loads of emojies like 50π then This means that the backend validation is incorect it probably checks for the length of the string instead of the bytes size of the string (in most emojies get encoded in 2 characters). |
e4a8ded
to
1c9256b
Compare
* fix(llm): fix long memo issue on Cardano * chore: update change log
* fix(llm): fix long memo issue on Cardano * chore: update change log
* fix(llm): fix long memo issue on Cardano * chore: update change log
β Checklist
npx changeset
was attached.π Description
Truncate Cardano memos in the input to prevent the transaction validation errors.
(Follow up to #8340 and #8604).
Screen.Recording.2024-12-05.at.11.59.52.mov
β Context
π§ Checklist for the PR Reviewers