Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): use a debounce on memotag field #8612

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(lld): use a debounce on memotag field #8612

merged 1 commit into from
Dec 6, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Dec 5, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add a debounce on memo tag field to avoid sending extra requests.
We still have an issue with Stacks that send 2 requests but it's on coin module side.

Before

Screen.Recording.2024-12-05.at.14.39.05.mov

After

Screen.Recording.2024-12-06.at.11.06.03.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Dec 5, 2024
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 3:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 3:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 3:29pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 3:29pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 5, 2024
@KVNLS KVNLS force-pushed the fix/live-15143 branch 2 times, most recently from 540f59c to d653fab Compare December 5, 2024 14:37
@KVNLS KVNLS marked this pull request as ready for review December 6, 2024 09:47
@KVNLS KVNLS requested review from a team as code owners December 6, 2024 09:47
@KVNLS KVNLS requested a review from themooneer December 6, 2024 10:03
LucasWerey

This comment was marked as outdated.

LucasWerey

This comment was marked as outdated.

@LucasWerey LucasWerey dismissed their stale review December 6, 2024 10:58

not wanted

@KVNLS KVNLS merged commit 874d911 into develop Dec 6, 2024
45 checks passed
@KVNLS KVNLS deleted the fix/live-15143 branch December 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants