Fix setup-caches skip-pnpm-cache behaviour
#8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-cache input correctly
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
themooneer
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
setup-cachesto:skip-pnpm-cacheinput correctly (i.e. iftrueit should skip the cache, if false it should not - not the other way around)true. Currently we want setup-caches to skip pnpm caches by default because our cache retrieval mechanism is much slower than doing a fresh download each time. When we fix this, I recommend switching the default back tofalseDeployment considerations
A ⌘+F of the repo shows that
skip-pnpm-cacheisn't actually specified in anysetup-cachesinvocations, therefore these 2 changes combined have no effect on existing workflows - it just makes theskip-pnpm-cacheparameter do what it says it'll do now, not the oppositeA test PR is set up here nevertheless, with build-web-tools-reusable forced to run (it uses setup-caches)