Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order the display of solana validators #8617

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Dec 5, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

In this PR we added another solana validator, but we didn't respect the order. The goal is to display Ledger By Chorus One first.

demo-ledger-solana-validators-order.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner December 5, 2024 15:51
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 5, 2024 4:01pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 5, 2024 4:01pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 5, 2024 4:01pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 5, 2024 4:01pm

Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Canestin Canestin merged commit 56fcd2a into develop Dec 5, 2024
54 checks passed
@Canestin Canestin deleted the fix/ledger-validator-order branch December 5, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants