Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set scroll indicator to right to prevent overlaping #8622

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Dec 6, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • set scroll indicator position on right to avoid overlap on Preferred currency screen.

Preview 📹 IOS

llm_scrollbar_ios_ok.mov

Preview 📹 no impact on android

llm_scrollbar_android_ok.mov

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-15057


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@themooneer themooneer requested a review from a team as a code owner December 6, 2024 06:35
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:49pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:49pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 6, 2024
@themooneer themooneer merged commit 64aae3b into develop Dec 6, 2024
41 checks passed
@themooneer themooneer deleted the fix/LIVE-15057 branch December 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants