Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(llm): 🐛 focus the memo tag input after clicking "Add Tag" #8627

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix(llm): 🐛 focus the memo tag input after clicking "Add Tag" #8627

merged 3 commits into from
Dec 12, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 6, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Focus on the memo tag input when clicking the drawers "Add Tag" button

Screen.Recording.2024-12-06.at.11.47.30.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner December 6, 2024 10:54
@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 11:15am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 11:15am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 11:15am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 11:15am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 6, 2024
@thesan thesan mentioned this pull request Dec 6, 2024
Merged
3 tasks
@thesan thesan force-pushed the fix/llm-memo-input-focus branch from ba418c0 to 6954821 Compare December 11, 2024 10:31
LucasWerey
LucasWerey previously approved these changes Dec 12, 2024
View reviewed changes
@thesan thesan force-pushed the fix/llm-memo-input-focus branch from 6954821 to 9211ec8 Compare December 12, 2024 11:15
@thesan thesan requested a review from a team as a code owner December 12, 2024 11:15
@thesan thesan merged commit 4b8e87d into develop Dec 12, 2024
41 checks passed
@thesan thesan deleted the fix/llm-memo-input-focus branch December 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

@qperrot qperrot qperrot approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

Assignees

@thesan thesan

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thesan @qperrot @LucasWerey @mcayuelas-ledger