Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-353][Playwright][Speculos] Improve CLI calls #8636

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[QAA-353][Playwright][Speculos] Improve CLI calls #8636

merged 1 commit into from
Dec 9, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 6, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD Speculos tests

📝 Description

Improving CLI calls on Playwright Speculos tests

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:05am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:05am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:05am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:05am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 6, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 6, 2024 17:31
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners December 6, 2024 17:31
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_353_playwright_improve_cli branch from 235d4e3 to fc04d9f Compare December 6, 2024 17:36
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_353_playwright_improve_cli branch from fc04d9f to 34594f2 Compare December 9, 2024 10:04
Base automatically changed from support/qaa-347 to develop December 9, 2024 11:31
@VicAlbr VicAlbr dismissed stale reviews from mcayuelas-ledger and bharamboure-ledger December 9, 2024 11:31

The base branch was changed.

@abdurrahman-ledger abdurrahman-ledger merged commit e7bd973 into develop Dec 9, 2024
42 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_353_playwright_improve_cli branch December 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger Awaiting requested review from mcayuelas-ledger

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdurrahman-ledger @bharamboure-ledger @mcayuelas-ledger