Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aptos): update aptos package #8661

Merged
merged 15 commits into from
Dec 12, 2024
Merged

feat(aptos): update aptos package #8661

merged 15 commits into from
Dec 12, 2024

Conversation

semeano
Copy link

@semeano semeano commented Dec 10, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

aptos package has been deprecated.
This PR replaces it with @aptos-labs/ts-sdk.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@semeano semeano requested a review from a team as a code owner December 10, 2024 15:04
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:35pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:35pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:35pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:35pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Dec 10, 2024
@semeano semeano requested a review from may01 December 12, 2024 11:10
may01
may01 approved these changes Dec 12, 2024
View reviewed changes
Copy link

@may01 may01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

libs/ledger-live-common/src/families/aptos/LedgerAccount.ts Outdated Show resolved Hide resolved
@semeano semeano requested a review from may01 December 12, 2024 15:32
@semeano semeano merged commit c70a5ec into feat/integrate-aptos Dec 12, 2024
23 of 25 checks passed
@semeano semeano deleted the feat/update-aptos-package branch December 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@may01 may01 may01 approved these changes

Assignees

@semeano semeano

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semeano @may01