Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): 🚦 do not validate empty Stellar memos #8667

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 11, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Remove invalid format error for Stellar empty hash and return type memo.

Before

Screen.Recording.2024-12-11.at.12.17.15.mov

After

Screen.Recording.2024-12-11.at.12.13.30.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner December 11, 2024 11:20
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:07pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:07pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:07pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:07pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 11, 2024
@cgrellard-ledger
Copy link
Contributor

The Continue button isn't disabled anymore when we select a type other than No memo and the memo value is empty. Are we sure we want to let the user be able to go to the next step in this case ?
Screenshot 2024-12-12 at 11 39 23

@thesan thesan force-pushed the fix/llm-memo-stellar-validation branch from 58fc08f to af4b6c4 Compare December 12, 2024 15:04
@thesan
Copy link
Contributor Author

thesan commented Dec 12, 2024

@cgrellard-ledger nice catch. As discussed internally I updated the logic so the type get's set to NO_MEMO when the value is empty.

@thesan thesan merged commit fa5d5a3 into develop Dec 12, 2024
41 checks passed
@thesan thesan deleted the fix/llm-memo-stellar-validation branch December 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants