Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpaca] Add pagination to listOperations #8673

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

sprohaszka-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update listOperations for Alpaca to allow a simple pagination mechanism.

❓ Context

  • JIRA or GitHub link: N/A

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Signed-off-by: Stéphane Prohaszka <[email protected]>
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:45pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:45pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 3:45pm

Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 12, 2024

Desktop Bundle Checks

Comparing a531549 against 4b8e87d.

✅ Previous issues have all been fixed.

Mobile Bundle Checks

Comparing a531549 against 4b8e87d.

✅ Previous issues have all been fixed.

qperrot
qperrot previously approved these changes Dec 12, 2024
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
@sprohaszka-ledger sprohaszka-ledger merged commit 9d8e34e into develop Dec 13, 2024
55 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the support/alpaca-tx-pagination branch December 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants