Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PROTECT-3467): recover banner link to go to login #8685

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cksanders
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Previously the Recover Banner was redirecting users based on they were still logged into Recover Live App, but if the user is not logged in to Recover Live app then this previous link would redirect them to the first step in the Backup flow.

We rather expect the user to be redirected to the login screen, then we can access their data and find out where they left off of the Backup flow and redirect them to the correct step.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested a review from a team as a code owner December 13, 2024 11:53
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 13, 2024 11:53am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 11:53am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 11:53am
web-tools ⬜️ Ignored (Inspect) Dec 13, 2024 11:53am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant