Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-375][Detox][Speculos] Fix Shard for push (bis) #8688

Merged

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 13, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix for [Push] Build and Test which has sharding but should not.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 13, 2024 0:20am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 0:20am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2024 0:20am
web-tools ⬜️ Ignored (Inspect) Dec 13, 2024 0:20am

@abdurrahman-ledger abdurrahman-ledger merged commit bead90a into develop Dec 13, 2024
31 of 35 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_375_sharding_android_test_fix branch December 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants