Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] Adding and reactivating swap tests + fixing ci #8692

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Dec 13, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Reactivating swap tests

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:21pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:21pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:21pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:21pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 13, 2024
@VicAlbr VicAlbr marked this pull request as ready for review December 13, 2024 15:30
@VicAlbr VicAlbr requested review from a team as code owners December 13, 2024 15:30
@VicAlbr VicAlbr force-pushed the support/fix-swap-ci branch from 4d4ec36 to 43c2642 Compare December 13, 2024 17:20
@VicAlbr VicAlbr merged commit eafb5d9 into develop Dec 13, 2024
41 checks passed
@VicAlbr VicAlbr deleted the support/fix-swap-ci branch December 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants