This repository has been archived by the owner on Mar 19, 2020. It is now read-only.
[TESTING PURPOSE] test bad internal script #235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettier should be better now removed terminator fixes fixed fixes oops
gre
reviewed
Feb 19, 2020
| @@ -10,6 +10,10 @@ import LoggerTransport from "~/logger/logger-transport-internal"; | |||
|
|
|||
| import { executeCommand, unsubscribeCommand, unsubscribeAllCommands } from "./commandHandler"; | |||
|
|
|||
| /* eslint-disable */ | |||
| // $FlowFixMe | |||
| coucou_arnaud = 1; | |||
There was a problem hiding this comment.
@IAmMorrow i'm not exactly sure if it's testing a bad case a boot (like a module failing to load). i think it would be better to do coucou_arnaud()
actually i'm still not sure to understand why it even crash anything (it's because we have some sort of script mode enabled?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a global scope error on the internal process script (internal/index.js)
Should crash and display an error on the renderer window with every platform