Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add onLongRelease and onRepeatPress events #20

Merged
merged 8 commits into from
Oct 25, 2024
Merged

feat: ✨ add onLongRelease and onRepeatPress events #20

merged 8 commits into from
Oct 25, 2024

Conversation

PA055
Copy link
Contributor

@PA055 PA055 commented Oct 4, 2024 •
edited
Loading

Resolves Issue #17

ion098
ion098 reviewed Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@ion098 ion098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good, please run clang-format on this

include/gamepad/button.hpp Outdated Show resolved Hide resolved
include/gamepad/button.hpp Outdated Show resolved Hide resolved
include/gamepad/button.hpp Outdated Show resolved Hide resolved
include/gamepad/button.hpp Outdated Show resolved Hide resolved
@PA055 PA055 requested a review from ion098 October 9, 2024 01:02
SizzinSeal
SizzinSeal reviewed Oct 25, 2024
View reviewed changes
src/main.cpp

void aPress1() {
last_repeat_press_time = pros::millis();
printf("A Pressed!\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not used std::cout?

SizzinSeal
SizzinSeal approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@SizzinSeal SizzinSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment on the example in src/main.cpp but its a tiny nitpick

ion098
ion098 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ion098 ion098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ion098 ion098 changed the title feat: ✨ add onLongRelease and onRepeatPressEvents feat: ✨ add onLongRelease and onRepeatPress events Oct 25, 2024
@ion098 ion098 merged commit 6bb7edf into LemLib:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion098 ion098 ion098 approved these changes

@SizzinSeal SizzinSeal SizzinSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More button events [REQUEST]
3 participants
@PA055 @SizzinSeal @ion098