Replace macros with associated type, add more descriptive names #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced the uses of the
TYPENAMES
andDIMS
macros with an associated typeQuantity::Self
, as well as gave some of the internal components more descriptive names. This should hopefully be a step towards making the errors generated by this library a bit more comprehensible. In a future PR I will work on addingstatic_asserts
as well.I also fixed some minor bugs in the units versions of the
<math>
functions.