Consider remote instance as dead if it returns any status 4xx or 5xx #5256
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
force-pushed
the
dead-instance-check-status
branch
from
729c706 to
bdab576
Compare
Nutomic
force-pushed
the
dead-instance-check-status
branch
from
bdab576 to
7410077
Compare
4 tasks
Nothing4You
reviewed
Dec 11, 2024
src/scheduled_tasks.rs
Outdated
| @@ -617,6 +617,7 @@ async fn build_update_instance_form( | |||
| } | |||
| .await; | |||
|
|
|||
| dbg!("reach here?"); | |||
There was a problem hiding this comment.
this probably wasn't supposed to be part of the PR
|
what happens in the case when the server is only temporarily down? Maybe using HTTP 410 as in the bug described might be a good idea. Then you can signal the intent for the server to be gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.