-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/coupling expansion #73
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces significant enhancements and refactoring to the codebase, focusing on expanding the coupling mechanisms and improving documentation and code quality. The changes include adding new methods, improving existing ones, and enhancing the documentation with detailed docstrings. Additionally, the pull request includes various bug fixes and code style improvements. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LemurPwned - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 12 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…o feat/ruff-transition
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Feat/ruff transition + IDMI
Feat/fmr dynamic
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Feat/reservoir interaction
Summary by Sourcery
This pull request introduces several new features, including multiple overloads for the AxialDriver class, new methods for the ScalarDriver class, and support for HDMI drivers. It also enhances documentation, refactors the Stack class, and updates plotting functions. New test cases have been added, and the documentation has been improved with new API paths. Additionally, the pre-commit configuration has been updated to exclude third-party directories.