-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm arm arm arm #19
arm arm arm arm #19
Conversation
@Lennolium Do I have to do anything else before you add it? |
You did everything needed, thanks! I'm just unsure right now: I could just rebuild the current (old) version with native arm support, or wait until I've finished the ground up new and polished new version with many bugfixes and added features etc. One question: why is the native arm support important to you? The current (old) x86_64 version also runs fine on newer m1/m2... macs with rosetta emulation. Cheers 🥂 |
@Lennolium I recently got an M2 mac, and I have not and do not plan to install rosetta. As much as it helps, there is enough support for most applications now where rosetta is not as needed. Also, there isn't really a good way to check if a program is using rosetta or not when installed, so rosetta could theoretically be on with an application that supports native silicon chips. I'll create a build.sh file separate for silicon macs later today too. |
Alright, this seems reasonable. I thought Rosetta was pre-installed on macOS. I will compile for arm64 tomorrow morning. Give me half a day and a download link will be ready. Thank you for your answers and help!
|
@Lennolium Just added. Universal binary would require more tweaking since brew binaries are located in separate locations on silicon macs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work! Approved 😊
Native arm64 version is now downloadable from the release tab.
P.S. you will be automatically added to the acknowledgment section in the README.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: