Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm arm arm arm #19

Merged
merged 2 commits into from
Nov 28, 2024
Merged

arm arm arm arm #19

merged 2 commits into from
Nov 28, 2024

Conversation

Bubba8291
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Lennolium Lennolium self-assigned this Nov 19, 2024
@Lennolium Lennolium added the enhancement New feature or request label Nov 19, 2024
@Bubba8291
Copy link
Contributor Author

@Lennolium Do I have to do anything else before you add it?

@Lennolium
Copy link
Owner

@Lennolium Do I have to do anything else before you add it?

You did everything needed, thanks! I'm just unsure right now: I could just rebuild the current (old) version with native arm support, or wait until I've finished the ground up new and polished new version with many bugfixes and added features etc. One question: why is the native arm support important to you? The current (old) x86_64 version also runs fine on newer m1/m2... macs with rosetta emulation.

Cheers 🥂

@Bubba8291
Copy link
Contributor Author

@Lennolium Do I have to do anything else before you add it?

You did everything needed, thanks! I'm just unsure right now: I could just rebuild the current (old) version with native arm support, or wait until I've finished the ground up new and polished new version with many bugfixes and added features etc. One question: why is the native arm support important to you? The current (old) x86_64 version also runs fine on newer m1/m2... macs with rosetta emulation.

Cheers 🥂

@Lennolium I recently got an M2 mac, and I have not and do not plan to install rosetta. As much as it helps, there is enough support for most applications now where rosetta is not as needed. Also, there isn't really a good way to check if a program is using rosetta or not when installed, so rosetta could theoretically be on with an application that supports native silicon chips.

I'll create a build.sh file separate for silicon macs later today too.

@Lennolium
Copy link
Owner

Alright, this seems reasonable. I thought Rosetta was pre-installed on macOS. I will compile for arm64 tomorrow morning. Give me half a day and a download link will be ready.

Thank you for your answers and help!
I will close this pr when the file is up ☺️

@Lennolium Do I have to do anything else before you add it?

You did everything needed, thanks! I'm just unsure right now: I could just rebuild the current (old) version with native arm support, or wait until I've finished the ground up new and polished new version with many bugfixes and added features etc. One question: why is the native arm support important to you? The current (old) x86_64 version also runs fine on newer m1/m2... macs with rosetta emulation.
Cheers 🥂

@Lennolium I recently got an M2 mac, and I have not and do not plan to install rosetta. As much as it helps, there is enough support for most applications now where rosetta is not as needed. Also, there isn't really a good way to check if a program is using rosetta or not when installed, so rosetta could theoretically be on with an application that supports native silicon chips.

I'll create a build.sh file separate for silicon macs later today too.

@Bubba8291
Copy link
Contributor Author

Bubba8291 commented Nov 27, 2024

@Lennolium Just added.

Universal binary would require more tweaking since brew binaries are located in separate locations on silicon macs.

Copy link
Owner

@Lennolium Lennolium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work! Approved 😊
Native arm64 version is now downloadable from the release tab.

P.S. you will be automatically added to the acknowledgment section in the README.

build-app-arm64.sh Dismissed Show dismissed Hide dismissed
build-app-arm64.sh Dismissed Show dismissed Hide dismissed
build-app-arm64.sh Dismissed Show dismissed Hide dismissed
build-app-arm64.sh Dismissed Show dismissed Hide dismissed
build-app-arm64.sh Dismissed Show dismissed Hide dismissed
src/swiftguard/const.py Dismissed Show dismissed Hide dismissed
src/swiftguard/utils/helpers.py Dismissed Show dismissed Hide dismissed
@Lennolium Lennolium merged commit 26d599f into Lennolium:main Nov 28, 2024
9 checks passed
@Bubba8291 Bubba8291 deleted the arm-arm-arm branch November 29, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants