🚀 feat: added pinojs and logger aggregation using asynclocalstorage implementation. [v.0] #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulofdev
changed the title
caioaletroca
requested changes
Dec 10, 2024
src/core/infrastructure/midaz/portfolios/midaz-create-portfolio-repository.ts
Outdated
Show resolved
Hide resolved
src/core/infrastructure/container-registry/container-registry.ts
Outdated
Show resolved
Hide resolved
caioaletroca
requested changes
Dec 10, 2024
src/app/api/organizations/[id]/ledgers/[ledgerId]/portfolios/[portfolioId]/route.ts
Outdated
Show resolved
Hide resolved
caioaletroca
approved these changes
Dec 10, 2024
src/app/api/organizations/[id]/ledgers/[ledgerId]/portfolios/[portfolioId]/route.ts
Outdated
Show resolved
Hide resolved
src/app/api/organizations/[id]/ledgers/[ledgerId]/portfolios/[portfolioId]/route.ts
Outdated
Show resolved
Hide resolved
| const { message, status } = await apiErrorHandler(error) | ||
| return NextResponse.json(portfolio) | ||
| } catch (error: any) { | ||
| console.error('Error getting portfolio', error) |
There was a problem hiding this comment.
Remover console.log()
| body: JSON.stringify(portfolio) | ||
| body: JSON.stringify(portfolio), | ||
| headers: { | ||
| 'X-Midaz-Id': midazId |
There was a problem hiding this comment.
O nome do header não é Midaz-Id? Segundo a documentação, seria esse o nome do atributo do header.
| @@ -11,6 +11,7 @@ export class MidazCreatePortfolioRepository | |||
| async create( | |||
| organizationId: string, | |||
| ledgerId: string, | |||
| midazId: string, | |||
There was a problem hiding this comment.
Não esta enviando o midazId para o midaz, precisa incluir no header.
src/lib/logger/request-context.ts
Outdated
| ...event | ||
| } | ||
|
|
||
| // switch (event.level) { |
There was a problem hiding this comment.
Remover comentários.
augusto-draxx
requested changes
Dec 11, 2024
augusto-draxx
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Midaz Console Pull Request Checklist
Pull Request Type
Checklist
Please check each item after it's completed.
Additional Notes
Obs: Please, always remember to target your PR to develop branch instead of main.