Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/MIDAZ-416 #417

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Fix/MIDAZ-416 #417

wants to merge 11 commits into from

Conversation

MartinezAvellan
Copy link
Member

@MartinezAvellan MartinezAvellan commented Dec 23, 2024 •
edited by maxwelbm
Loading

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Audit
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan requested a review from a team as a code owner December 23, 2024 10:37
@MartinezAvellan MartinezAvellan self-assigned this Dec 23, 2024
@MartinezAvellan MartinezAvellan added don't merge Don't merge this PR refactor Refactor the code domain:transactions Responsible for transactions and operations labels Dec 23, 2024
@MartinezAvellan MartinezAvellan changed the title Fix/MIDAZ416 Fix/MIDAZ-416 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelbm maxwelbm maxwelbm approved these changes

@qnen qnen qnen approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

Assignees

@MartinezAvellan MartinezAvellan

Labels
domain:transactions Responsible for transactions and operations don't merge Don't merge this PR refactor Refactor the code
Projects
None yet
Milestone
Multi-Asset Transactions
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinezAvellan @ClaraTersi @qnen @maxwelbm @lerian-studio