Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvncserver: Enable ExtendedClipboard encoding only when app signals support for UTF-8 cut-text #639

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

gujjwal00
Copy link
Contributor

A UTF-8 capable client will usually prefer to send cut-text via ExtendedClipboard encoding once libvncserver declares support for it. If app doesn't assign a setXCutTextUTF8() callback, the default handler is used which is no-op. So client-to-server clipboard transfer will not work.

Re: #638

… support for UTF-8 cut-text

A UTF-8 capable client will usually prefer to send cut-text via ExtendedClipboard encoding once libvncserver declares support for it. If app doesn't assign a setXCutTextUTF8() callback, the default handler is used which is no-op. So client-to-server clipboard transfer will not work.

Re: LibVNC#638
@bk138 bk138 merged commit 4b3b9d9 into LibVNC:master Nov 26, 2024
12 checks passed
@gujjwal00 gujjwal00 deleted the restrict-ext-clipboard branch December 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libvncserver should not advertize ExtendedClipboard support if server app doesn't supoort it
2 participants