-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing/forces update #1076
Testing/forces update #1076
Conversation
A geneartor that sets num_gpus based on the x value
# Seed random streams for each worker, particularly for gen_f | ||
persis_info = add_unique_random_streams({}, nworkers + 1) | ||
# Seed random streams for each worker, particularly for gen_f | ||
ensemble.add_random_streams() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use ensemble.persis_info = add_unique_random_streams({}, ensemble.nworkers + 1)
if you think its more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'm realising it means an extra import (from tools) which is a pain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. That's one of the reasons I made Ensemble.add_random_streams()
originally, I think I forgot to mention. Avoid an import, keep it simple for 75% of our tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Update forces tests.
For relevant forces tests
Other capabilities
Tests
Update tutorials