Experimental/jlnav plus shuds asktell #1307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tal/class_gens_ask_tell
…tal/class_gens_ask_tell
…erator, asks receive num_points (which defaults to n idle sim workers). batch_size and initial_batch_size attributes of a Generator subclass are also honored
…tal/class_gens_ask_tell
…ance to gen_f field)
…nal persistent gen_f via sends and recvs
…rt persistent_gen upon calling initial_ask
… manager/worker to initialize itself, more adjustments
…oop temp var overwriting import, bump number of "sims"
shuds13
reviewed
Oct 30, 2024
libensemble/gen_classes/aposmm.py
Outdated
| self._n_total_results += len(results) | ||
|
|
||
| if not self._told_initial_sample and self._enough_initial_sample: | ||
| self._tell_buf = self._tell_buf[self._tell_buf["sim_id"] != 0] |
…in initial_sample_size check, initing/fixing sim_ids to be -1, and can specify nworkers as kwarg to aposmm class
…n optimas when roughly enough initial sample points have been slotted in
… the last ask, another important indicator is that the last point produced has been returned to the gen. this gets us past the initial sample now, but now aposmm seems to return empty arrays?
shuds13
reviewed
Oct 30, 2024
libensemble/generators.py
Outdated
| ) | ||
| else: | ||
| self.inbox.put((tag, None)) | ||
| self.inbox.put((0, np.copy(results))) |
There was a problem hiding this comment.
I'll note some of these copies are presumably not needed if using a process. Its convenient for keeping it easy to swap between process and thread. But that could also be dealt with by using a function.
shuds13
reviewed
Oct 30, 2024
| self._told_initial_sample = False | ||
|
|
||
| def _slot_in_data(self, results): | ||
| """Slot in libE_calc_in and trial data into corresponding array fields. *Initial sample only!!*""" |
There was a problem hiding this comment.
this is what you want:
self._tell_buf[self._n_buffd_results:self._n_buffd_results + len(results)] = results
shuds13
reviewed
Nov 5, 2024
…aposmm tiny changes for slotting in data back from the waket/optimas workflow
shuds13
reviewed
Nov 14, 2024
|
|
||
| H, persis_info, _ = workflow.run() | ||
|
|
||
| # Perform the run |
* Use QComm in QCommProcess for comms * Remove thread locked comm in executor * Add conditional code for executor forwarding * Remove extra setup() call * Use correct outbox queue
use macOS-supported queue condition
…d when data goes into gen.
Swap "sim_id" with "_id" when data leaves gen and vice-versa. For ask/tell standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See checklist in #1307 (review)