Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gpCAM.py #1465

Open
wants to merge 1 commit into
base: experimental/jlnav_plus_shuds_asktell
Choose a base branch
from

Conversation

roussel-ryan
Copy link

Fixes some small issues preventing tell in the generator standard

@jlnav jlnav requested a review from shuds13 November 25, 2024 19:04
@@ -74,7 +74,7 @@ def ask_numpy(self, n_trials: int) -> npt.NDArray:
input_set=np.column_stack((self.lb, self.ub)),
n=n_trials,
pop_size=n_trials,
acquisition_function="total correlation",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should prob be passed as option, with sensible default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also there is "MINIMIZE", "MAXIMIZE" keywords. If we added 'EXPLORE', that would probably be "total correlation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants