Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap "sim_id" with "_id" when data leaves gen and vice-versa. For ask/tell standard #1480

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Dec 3, 2024

No description provided.

@jlnav jlnav merged commit ab09b9f into experimental/jlnav_plus_shuds_asktell Dec 3, 2024
14 checks passed
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (9d07e6c) to head (64b6401).
Report is 2 commits behind head on experimental/jlnav_plus_shuds_asktell.

Additional details and impacted files
@@                            Coverage Diff                            @@
##           experimental/jlnav_plus_shuds_asktell    #1480      +/-   ##
=========================================================================
+ Coverage                                  78.88%   78.90%   +0.01%     
=========================================================================
  Files                                         81       81              
  Lines                                       8072     8078       +6     
  Branches                                    1196     1200       +4     
=========================================================================
+ Hits                                        6368     6374       +6     
  Misses                                      1499     1499              
  Partials                                     205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav jlnav deleted the asktell/under_id branch December 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants