enable no-param-reassign rule

LibrePhotos · Nov 5, 2023 · a93432d · a93432d
1 parent bd0480d
commit a93432d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -7,7 +7,6 @@ module.exports = {
   extends: ["airbnb", "airbnb-typescript", "airbnb/hooks", "prettier"],
   plugins: ["prettier"],
   rules: {
-    "no-param-reassign": "off",
     "import/prefer-default-export": "off",
     "import/no-cycle": "off",
     "react/jsx-props-no-spreading": "off", // some Mantine components need to use spread operator

diff --git a/src/components/locationLink.tsx b/src/components/locationLink.tsx
@@ -195,6 +195,7 @@ export function LocationLink(props: Props) {
                         rx={5}
                         stroke="#dddddd"
                         onClick={() => {
+                          // eslint-disable-next-line no-param-reassign
                           node.data.isExpanded = !node.data.isExpanded;
                         }}
                       />
@@ -212,6 +213,7 @@ export function LocationLink(props: Props) {
                         strokeOpacity={!node.data.children ? 1 : 1}
                         rx={!node.data.children ? 5 : 5}
                         onClick={() => {
+                          // eslint-disable-next-line no-param-reassign
                           node.data.isExpanded = !node.data.isExpanded;
                         }}
                       />

diff --git a/src/components/react-pig/computeLayout.js b/src/components/react-pig/computeLayout.js
@@ -17,7 +17,7 @@
  */
 import getMinAspectRatio from "./utils/getMinAspectRatio";
 
-export default function computeLayout({ imageData, settings, totalHeight, wrapperWidth, scaleOfImages }) {
+export default function computeLayout({ imageData, settings, wrapperWidth, scaleOfImages }) {
   // Compute the minimum aspect ratio that should be applied to the rows.
   const minAspectRatio = getMinAspectRatio(wrapperWidth, scaleOfImages);
 
@@ -82,7 +82,7 @@ export default function computeLayout({ imageData, settings, totalHeight, wrappe
     }
   });
   // No space below the last image
-  totalHeight = translateY - settings.gridGap;
+  const totalHeight = translateY - settings.gridGap;
 
   return {
     imageData: tempImgData,

diff --git a/src/components/react-pig/computeLayoutGroups.js b/src/components/react-pig/computeLayoutGroups.js
@@ -1,7 +1,7 @@
 // like computeLayout but specific for groups. Could combine them but it might get messy
 import getMinAspectRatio from "./utils/getMinAspectRatio";
 
-export default function computeLayoutGroups({ imageData, settings, totalHeight, wrapperWidth, scaleOfImages }) {
+export default function computeLayoutGroups({ imageData, settings, wrapperWidth, scaleOfImages }) {
   // Compute the minimum aspect ratio that should be applied to the rows.
   const minAspectRatio = getMinAspectRatio(wrapperWidth, scaleOfImages);
   const groupTitleHeight = 50; // wrapperWidth < settings.breakpoint ? 50 : 50
@@ -87,7 +87,7 @@ export default function computeLayoutGroups({ imageData, settings, totalHeight,
   });
 
   // No space below the last image
-  totalHeight = translateY - settings.gridGap;
+  const totalHeight = translateY - settings.gridGap;
 
   return {
     imageData: tempGroupData,

diff --git a/src/store/faces/faceSlice.ts b/src/store/faces/faceSlice.ts
@@ -95,6 +95,7 @@ const faceSlice = createSlice({
       const { tab, position } = action.payload;
       if (tab in state.tabs) {
         // @ts-ignore
+        // eslint-disable-next-line no-param-reassign
         state.tabs[tab].scrollPosition = position;
       }
     },