new front end changes for the download api #406

AnkurPrabhu · 2023-11-12T09:17:09Z

@derneuere @sickelap
related backend pr: LibrePhotos/librephotos#1057
related issue : LibrePhotos/librephotos#375

AnkurPrabhu · 2023-11-12T09:18:19Z

@derneuere new pr for the download api as i was not able to find how to remove the package.json file from pr also
can you tell me what did u mean by Please format the code with our configurations

sickelap · 2023-11-12T09:38:19Z

@AnkurPrabhu make sure that all PR checks are passing. Also enable pre-commit checks if you haven't done so yet. You can do that by running npm run prepare, having done that when you committing checks will run. Also look into sonar report and fix issues where it make sense.

sickelap · 2023-11-12T09:42:21Z

src/App.tsx

@@ -1,6 +1,6 @@
 import type { ColorScheme } from "@mantine/core";
 import { AppShell, ColorSchemeProvider, MantineProvider } from "@mantine/core";
-import { Notifications } from "@mantine/notifications";
+import { NotificationsProvider } from "@mantine/notifications";


This will make the build to fail. Mantine v6 does not have NotificationsProvider anymore.

got it will make a new image and then push my pr will fix my issues ig

sickelap · 2023-11-12T09:49:29Z

src/actions/photosActions.ts

      shared: val_shared,
      target_user_id: target_user.id,
    })
      .then(() => {
-        let notificationMessage = i18n.t("toasts.unsharephoto", {
+        let notificationMessage = i18n.t<string>("toasts.unsharephoto", {


If you must to specify the type, it should be i18n.t<string|TemplateStringsArray, TOptions, string>("...").
As it looks too verbose and does not provide any value I suggest to remove type from translation function completely (as it was before) and let the type be inferred.

AnkurPrabhu · 2023-11-12T10:05:20Z

@AnkurPrabhu make sure that all PR checks are passing. Also enable pre-commit checks if you haven't done so yet. You can do that by running npm run prepare, having done that when you committing checks will run. Also look into sonar report and fix issues where it make sense.

@sickelap thing is my pr only had 2 issues which were of a variable being used in function call when i rebased it ,it showed me 37 errors which were not on even related to my code so i pushed them

sickelap · 2023-11-12T10:11:02Z

could it be that you rebased of the wrong commit?

AnkurPrabhu · 2023-11-12T10:17:11Z

I had the latest dev branch-
I synced my fork then did a git pull on the dev branch of my local and then rebased that dev branch on my download branch

AnkurPrabhu · 2023-11-12T10:38:16Z

these are the errors i am getting not related to my code

also we should implement the commit hooks like: -
if any commit hook fails dont rollback other commit hook changes exampel prettier and other formatters

@sickelap any other code changes ? or thats it ?

sickelap · 2023-11-12T10:39:48Z

make sure PR checks are passing

AnkurPrabhu · 2023-11-12T14:18:14Z

@sickelap

these are the errors i am getting not related to my code

also we should implement the commit hooks like: - if any commit hook fails dont rollback other commit hook changes exampel prettier and other formatters

@sickelap any other code changes ? or thats it ?

sickelap

I have made the suggestions for most if not all lint check errors

sickelap · 2023-11-12T16:57:00Z

src/actions/photosActions.ts

    });
+    return Server.post("photos/download", {
+      image_hashes: image_hashes,


Suggested change

image_hashes: image_hashes,

image_hashes,

sickelap · 2023-11-12T16:57:22Z

src/actions/photosActions.ts

+  const startDownloadProcess = () => {
+    showNotification({
+      message: "Download Starting ...",
+      title: i18n.t<string>("toasts.downloadstart"),


Suggested change

title: i18n.t<string>("toasts.downloadstart"),

title: i18n.t("toasts.downloadstart"),

sickelap · 2023-11-12T16:57:39Z

src/actions/photosActions.ts

 // eslint-disable-next-line import/no-cycle
-import { Server } from "../api_client/apiClient";
+import { Server,serverAddress } from "../api_client/apiClient";


Suggested change

import { Server,serverAddress } from "../api_client/apiClient";

import { Server, serverAddress } from "../api_client/apiClient";

sickelap · 2023-11-12T16:58:14Z

src/actions/photosActions.ts

+              else if (status === "FAILURE") {
+                showNotification({
+                  message: "Download failed",
+                  title: i18n.t<string>("toasts.downloaderror"),


Suggested change

title: i18n.t<string>("toasts.downloaderror"),

title: i18n.t("toasts.downloaderror"),

sickelap · 2023-11-12T16:58:27Z

src/actions/photosActions.ts

    dispatch({ type: "SET_PHOTOS_SHARED" });
    Server.post(`photosedit/share/`, {
-      image_hashes,
+      image_hashes: image_hashes,


Suggested change

image_hashes: image_hashes,

image_hashes,

sickelap · 2023-11-12T17:42:06Z

src/actions/photosActions.ts

      });
  };
 }

 export function editPhoto(image_hash: string, photo_details: any) {
-  return function cb(dispatch: Dispatch<any>) {
+  return function (dispatch: Dispatch<any>) {


Suggested change

return function (dispatch: Dispatch<any>) {

return function cb(dispatch: Dispatch<any>) {

sickelap · 2023-11-12T17:42:17Z

src/actions/photosActions.ts

+          message: i18n.t<string>("toasts.editphoto"),
+          title: i18n.t<string>("toasts.editphototitle"),


Suggested change

message: i18n.t<string>("toasts.editphoto"),

title: i18n.t<string>("toasts.editphototitle"),

message: i18n.t("toasts.editphoto"),

title: i18n.t("toasts.editphototitle"),

sickelap · 2023-11-12T17:42:38Z

src/actions/photosActions.ts

+        dispatch({ type: "EDIT_PHOTO_REJECTED" });
+        console.error(error);


Suggested change

dispatch({ type: "EDIT_PHOTO_REJECTED" });

console.error(error);

dispatch({ type: "EDIT_PHOTO_REJECTED", payload: error });

sickelap · 2023-11-12T17:42:45Z

src/locales/en/translation.json

@@ -253,7 +253,7 @@
    "favorites": "Favorites",
    "mypublicphotos": "My Public Photos",
    "photos": "Photos",
-    "videos": "Videos",
+    "videos":"Videos",


Suggested change

"videos":"Videos",

"videos": "Videos",

sickelap · 2023-11-12T17:42:59Z

src/locales/en/translation.json

@@ -351,7 +351,7 @@
    "notimestamp": "Photos without Timestamps",
    "hidden": "Hidden Photos",
    "favorite": "Favorite Photos",
-    "videos": "Videos",
+    "videos" :"Videos",


Suggested change

"videos" :"Videos",

"videos": "Videos",

sonarqubecloud · 2023-11-12T21:09:58Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
30.1% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

AnkurPrabhu · 2023-11-12T21:14:04Z

all the eslint issues are solved and i currently see 0 errors so should be good to go learned a lot of new things while solving these errors, @sickelap sorry to bother you but your suggestions did help a lot thank-you also did u manually point all of these issues or used some extension to do it ? (more than 56 suggestions i think) sorry for the trouble

AnkurPrabhu · 2023-11-12T21:15:36Z

@derneuere @sickelap pls let me know if there are any changes needed lets merge this asap I want to see this change live Im really excited for this one 🥂

sickelap · 2023-11-13T09:54:05Z

all the eslint issues are solved and i currently see 0 errors so should be good to go learned a lot of new things while solving these errors, @sickelap sorry to bother you but your suggestions did help a lot thank-you also did u manually point all of these issues or used some extension to do it ? (more than 56 suggestions i think) sorry for the trouble

Not a problem. Suggestions is a feature of GitHub PR review.

sickelap · 2023-11-13T09:59:28Z

Please update LibrePhotos/librephotos#1057 so all checks are green. After that's done I will verify the feature and both PRs can merged

front end changes

dc3d679

sickelap reviewed Nov 12, 2023

View reviewed changes

changes

1a79900

sickelap merged commit 6ae3035 into LibrePhotos:dev Nov 14, 2023
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new front end changes for the download api #406

new front end changes for the download api #406

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading

AnkurPrabhu commented Nov 12, 2023

sickelap commented Nov 12, 2023

sickelap Nov 12, 2023

AnkurPrabhu Nov 12, 2023

sickelap Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

sickelap commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading

sickelap commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

sickelap left a comment

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sickelap Nov 12, 2023

sonarqubecloud bot commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading

sickelap commented Nov 13, 2023

sickelap commented Nov 13, 2023

	title: i18n.t<string>("toasts.downloadstart"),
	title: i18n.t("toasts.downloadstart"),

	import { Server,serverAddress } from "../api_client/apiClient";
	import { Server, serverAddress } from "../api_client/apiClient";

	title: i18n.t<string>("toasts.downloaderror"),
	title: i18n.t("toasts.downloaderror"),

	return function (dispatch: Dispatch<any>) {
	return function cb(dispatch: Dispatch<any>) {

		message: i18n.t<string>("toasts.editphoto"),
		title: i18n.t<string>("toasts.editphototitle"),

		dispatch({ type: "EDIT_PHOTO_REJECTED" });
		console.error(error);

	dispatch({ type: "EDIT_PHOTO_REJECTED" });
	console.error(error);
	dispatch({ type: "EDIT_PHOTO_REJECTED", payload: error });

new front end changes for the download api #406

new front end changes for the download api #406

Conversation

AnkurPrabhu commented Nov 12, 2023 • edited Loading

AnkurPrabhu commented Nov 12, 2023

sickelap commented Nov 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnkurPrabhu commented Nov 12, 2023

sickelap commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023 • edited Loading

sickelap commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

sickelap left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023

AnkurPrabhu commented Nov 12, 2023 • edited Loading

sickelap commented Nov 13, 2023

sickelap commented Nov 13, 2023

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading

AnkurPrabhu commented Nov 12, 2023 •

edited

Loading