Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force refetching faces when adding a new person #407

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

derneuere
Copy link
Member

This pull requests fixes LibrePhotos/librephotos#1067

When adding a person, it could happen that a person was added, but never was fetched as it thought that this particular faces is already loaded. By reseting the groups faces will get fetched again for all groups.

@derneuere derneuere requested a review from sickelap November 13, 2023 11:52
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@sickelap sickelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK for the time being as we did not migrate faces to RTK yet. Later this will be refactored to invalidate tags and it will refetch automatically.

@derneuere
Copy link
Member Author

Yes, sounds like a good plan :)

@derneuere derneuere merged commit 58fd743 into dev Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"unkown - others" not automaticaly refreshed
2 participants