Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #582

Merged
merged 16 commits into from
Dec 10, 2024
Merged

Improvements #582

merged 16 commits into from
Dec 10, 2024

Conversation

sickelap
Copy link
Contributor

@sickelap sickelap commented Dec 7, 2024 •
edited
Loading

various improvements:

  • linting fixes. we are not fully "clean" of linting errors but we are close
  • removed quite few eslint disable rules as they no longer apply
  • added missing styles for site search that I forgot to add in restore site search functionality #581
  • update attributes of some components to use correct Mantine 7 attributes
  • fixed issue with lightbox
  • got rid of warnings in the console by marking certain properties as not required in Pig Tile and GroupHeader

@sickelap sickelap marked this pull request as draft December 7, 2024 22:53
@sickelap sickelap marked this pull request as ready for review December 8, 2024 14:39
@derneuere
Copy link
Member

Looks good!

@derneuere derneuere merged commit d7a506e into LibrePhotos:dev Dec 10, 2024
1 check failed
@sickelap sickelap deleted the improvements branch December 10, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sickelap @derneuere