WIP: Ignore mp3 files that mp3gain cannot process #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the validator, sometimes audio files either have a typo in their path, or aren't actually audio files (when this patch was being tested, the offending files were HTML files from a 301 redirect response). In those cases, mp3gain does not return any useful output. Specifically, instead of printing the header line plus the actually useful line, it just prints the header line, with an error message going to stderr (which we ignore because we only look at stdout). This patch just makes the validator skip any such files. Resolves LibriVox#119 Change-Id: Id08899ef6f415aeece6912e9676a7bcab05caf81
|
7f63d1c has superceded this, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the validator, sometimes audio files either have a typo in their
path, or aren't actually audio files (when this patch was being
tested, the offending files were HTML files from a 301 redirect
response). In those cases, mp3gain does not return any useful output.
Specifically, instead of printing the header line plus the actually
useful line, it just prints the header line, with an error message
going to stderr (which we ignore because we only look at stdout).
This patch just makes the validator skip any such files.
Resolves #119