Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move template language selection. #180

Closed

Conversation

redrun45
Copy link
Collaborator

It's now the first thing to choose, rather than up in the corner. Someone already had the 'Select a language for your template' string translated and ready for this change.
Fixes #74
Sorry for the mess of PRs.

It's now the first thing to choose, rather than up in the corner.  Someone already had the 'Select a language for your template' string translated and ready for this change.
@redrun45
Copy link
Collaborator Author

Pending a check on the translations by other admin.
On the technical side, I don't know whether this should be inside a "fieldset" HTML element, and if that's likely to cause other trouble. I copied it from the other elements below, but this chooser isn't part of the "form" proper.

@redrun45 redrun45 changed the title Move template language selection. [WIP] Move template language selection. Dec 31, 2023
@redrun45
Copy link
Collaborator Author

redrun45 commented Mar 3, 2024

The positioning on this doesn't look quite right in hindsight. I'll take another stab at defining CSS classes, and propose again after admins think it looks OK.

@redrun45 redrun45 closed this Mar 3, 2024
@redrun45 redrun45 deleted the foreground-language-chooser branch March 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Project Template Generator, move the box for the different language choices in a more conspicuous spot
1 participant