Add a link to Archive from Advanced Search page #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm convinced there's some CSS thing I'm supposed to be adding, but matching the h5 up above... at least isn't adding to the mess?
notartom
reviewed
Mar 9, 2024
| @@ -101,6 +101,10 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <h5>Still can't find what you're looking for? Try searching <a rel="noopener" target="_blank" href="https://archive.org/details/librivoxaudio">Internet Archive's LibriVox Audiobook Collection</a> | |||
There was a problem hiding this comment.
I tend to dislike messing with the defaults for opening links, as it breaks expectations and removes control from the user (middle click to open in new tab only if I chose to), is there a reason you went with _blank? As far as I can tell, this isn't consistent with the other links on the advanced search page either.
There was a problem hiding this comment.
Good point. Our 'Internet Archive Page' links from the individual works' pages should probably be the model here.
Removed rel=noopener and target=_blank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one with admin consensus: 👍
I tried combinations of things, but it doesn't look bad as just an h5. And there's no business logic to get wrong. This can go live at your convenience. 😃