More accurate pagination URLs #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the pagination URLs just pointed to `#`, which meant that you couldn't do things like 'Open in new tab' or bookmark a specific page if you were sorting by Release Date. This commit helps solve those problems on the Reader, Group, and Author pages by: * Specifying a better URL for the pagination links (solves for 'Open in new tab') * Pushing the `search_order` parameter into the page URL when new pages are fetched from the server (solves for accurate bookmarking) (I haven't fixed it on the Search pages.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the pagination URLs just pointed to
#, which meantthat you couldn't do things like 'Open in new tab' or bookmark a
specific page if you were sorting by Release Date.
This commit helps solve those problems on the Reader, Group, and Author
pages by:
new tab')
search_orderparameter into the page URL when new pagesare fetched from the server (solves for accurate bookmarking)
(I haven't fixed it on the Search pages.)