Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update(ci): github action's artifact upgrade v4 #435

Conversation

alleeclark
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

  • Updates actions's artifacts from v3 to v4
  • Adds the merge-multiple to download so artifacts will get loaded into the same directory

We received the email below stating that we need to upgrade by January.

image

Here is the recommended upgrade guide that I followed.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (0a97def) to head (76a67ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #435   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        35     35           
  Lines      5106   5106           
===================================
  Hits       4006   4006           
  Misses     1100   1100           

@alleeclark alleeclark force-pushed the fix_allee_github_artifacts_upload_and_download_eol_v4 branch from 7211fbc to 862517c Compare December 16, 2024 22:48
@alleeclark alleeclark marked this pull request as ready for review December 17, 2024 13:09
@alleeclark alleeclark requested a review from Borda as a code owner December 17, 2024 13:09
@Borda Borda changed the title Update (ci): github action's artifact upgrade due to EOL for versions less than 4 Update(ci): github action's artifact upgrade v4 Dec 17, 2024
@Borda Borda merged commit bd116a4 into Lightning-AI:main Dec 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants