-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forecast fix for Home Assistant >= 2024.4.0 #150
Conversation
I tried my best for tests to pass, both |
@Limych any chance for a review? 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, merge this PR
Please, fix errors in requirements and add unit tests for your code. |
@Limych Thanks for taking a look at this PR. As I mentioned earlier, I can't fix all the tests needed for this PR. I hope you can take this PR and make the modifications yourself so the main test can pass. If somebody else knows how to mock a service call to a weather integration, and can help me with it, I'd appreciate it. At the moment, this is as far as I can go. For anybody else following this PR and needs a fix immediately, check the two following files in this PR (or my fork), and copy/paste them under your setup: |
Ok, thanks for your work. Unfortunately, I cannot accept PR without full-fledged unit tests, because then no one will do them and this will entail a deterioration in the quality of the code of the entire component. |
@Limych after some googling and reading, I found out how to mock a service call. The unit test has been fixed to implement it, and the tests should be passing. Can you approve it so the workflow runs? If there are any additional errors after that, I could fix them. |
@Limych please merge it until the end of October 😅 Edit: Also please approve the workflow |
Thanks ❤️ |
Breaking change
Proposed change
Fix support for new service request for forecast
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast custom_components
)If user exposed functionality or configuration variables are added/changed: