Merge pull request #17 from bycosta/master

Fix unpack error for arrays with string keys.
LinioIT · Apr 4, 2017 · 13238df · 13238df
2 parents 44eb9dd + 5fa2f63
commit 13238df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Instantiator/ConstructInstantiator.php b/src/Instantiator/ConstructInstantiator.php
@@ -7,6 +7,6 @@ class ConstructInstantiator implements InstantiatorInterface
 {
     public function instantiate(string $class, array $data)
     {
-        return new $class(...$data);
+        return new $class(...array_values($data));
     }
 }
diff --git a/tests/Instantiator/ConstructInstantiatorTest.php b/tests/Instantiator/ConstructInstantiatorTest.php
@@ -3,6 +3,8 @@
 
 namespace Linio\Component\Input\Instantiator;
 
+use Linio\Component\Input\Constraint\Enum;
+
 class ConstructInstantiatorTest extends \PHPUnit_Framework_TestCase
 {
     public function testIsCreatingInstances()
@@ -12,4 +14,11 @@ public function testIsCreatingInstances()
         $this->assertInstanceOf('ErrorException', $instance);
         $this->assertEquals(new \ErrorException('foobar'), $instance);
     }
+
+    public function testIsHandlingArraysWithStringKeys()
+    {
+        $instantiator = new ConstructInstantiator();
+        $instance = $instantiator->instantiate(Enum::class, ['foo' => [1, 2], 'bar' => 'message']);
+        $this->assertEquals(new Enum([1, 2], 'message'), $instance);
+    }
 }