Dont check for EAN to exist

LinioIT · Oct 24, 2023 · 5083e0d · 5083e0d
1 parent eb116b6
commit 5083e0d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/Model/Product/BaseProduct.php b/src/Model/Product/BaseProduct.php
@@ -69,7 +69,7 @@ abstract class BaseProduct implements JsonSerializable
     protected $brand;
 
     /**
-     * @var string
+     * @var string|null
      */
     protected $productId;
 
@@ -171,7 +171,7 @@ public function getBrand(): Brand
         return $this->brand;
     }
 
-    public function getProductId(): string
+    public function getProductId(): ?string
     {
         return $this->productId;
     }
@@ -313,7 +313,7 @@ public function jsonSerialize(): stdClass
         return $serialized;
     }
 
-    protected static function ValidateArguments(string $sellerSku, string $name, string $description, string $productId): void
+    protected static function ValidateArguments(string $sellerSku, string $name, string $description): void
     {
         if (empty($sellerSku)) {
             throw new EmptyArgumentException('SellerSku');
@@ -326,8 +326,5 @@ protected static function ValidateArguments(string $sellerSku, string $name, str
         if (empty($description)) {
             throw new EmptyArgumentException('Description');
         }
-        if (empty($productId)) {
-            throw new EmptyArgumentException('ProductId');
-        }
     }
 }
diff --git a/src/Model/Product/Contract/ProductInterface.php b/src/Model/Product/Contract/ProductInterface.php
@@ -35,7 +35,7 @@ public function getDescription(): string;
 
     public function getBrand(): Brand;
 
-    public function getProductId(): string;
+    public function getProductId(): ?string;
 
     public function getTaxClass(): ?string;
 

diff --git a/src/Model/Product/GlobalProduct.php b/src/Model/Product/GlobalProduct.php
@@ -67,7 +67,7 @@ public static function fromBasicData(
         ?Images $images = null,
         ?string $qcStatus = null
     ): self {
-        self::ValidateArguments($sellerSku, $name, $description, $productId);
+        self::ValidateArguments($sellerSku, $name, $description);
 
         $product = new static();
 

diff --git a/src/Model/Product/Product.php b/src/Model/Product/Product.php
@@ -83,7 +83,7 @@ public static function fromBasicData(
         ?Images $images = null,
         ?array $overrideAttributes = []
     ): self {
-        self::ValidateArguments($sellerSku, $name, $description, $productId);
+        self::ValidateArguments($sellerSku, $name, $description);
 
         if ($price <= 0) {
             throw new InvalidDomainException('Price');