Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-notifier): fix twitter job and conditions #271

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

This PR fixes the twitter notification job, as well as the conditions for the notification. i.e. the notification will only be sent if the release is NOT a pre-release.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix(release-notifier)-fix-twitter-job-and-conditions branch from d90a39a to 61c96d5 Compare October 9, 2023 23:41
@ReenigneArcher ReenigneArcher merged commit f7c8cea into master Oct 10, 2023
16 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(release-notifier)-fix-twitter-job-and-conditions branch October 10, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant