Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct logic in release notifier #334

Merged
merged 1 commit into from
May 24, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Now that all repos are on pre-release logic, we can fix the release notifier to only send updates when a stable release is published. Editing from pre-release to non pre-release should trigger this workflow.

This hasn't run in a while, so it's unknown which ones still work... but in any event, this should be an improvement.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix-use-correct-logic-in-release-notifier branch from 1e9a221 to bba9179 Compare May 24, 2024 02:29
@ReenigneArcher ReenigneArcher merged commit 4900849 into master May 24, 2024
15 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-use-correct-logic-in-release-notifier branch May 24, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant